Skip Navigation

Accommodation Tables

Travel Forums Wiki Travel Guide Accommodation Tables

Page

Last Post

21. Posted by Peter (Admin 5789 posts) 7y

Quoting Utrecht

3. The list of cities for Germany (just tried Berlin) is not working, there is none. edit: Spain the same

Hmm, just tried replicating this but couldn't. I managed to create lists for both Berlin and Barcelona in testing.

22. Posted by Utrecht (Moderator 5595 posts) 7y

Hi Peter,

Thanks.
Well, maybe only the rows with TPID is ok, that way, some contributions that allready have been made by others, don't go lost now.

I have seen some parts which were islands (like Vancouver or Langkawi for example). But I guess that's ok. I also added some indeed at countries (mainly small islands in the pacific or caribbean, that's it).

But again: it looks pretty good doesn't it.

Thanks for the work!
Michael

23. Posted by Peter (Admin 5789 posts) 7y

Quoting Utrecht

Well, maybe only the rows with TPID is ok, that way, some contributions that allready have been made by others, don't go lost now.

Ok, I think I'll try that. It's still not perfect since it is possible to add more information even if there is a TPID, but at least it's an improvement hopefully. Maybe hold off on too many edits until I've done it, because the calculation happens after you make an edit. Not a big deal, since the next edit will recalculate everything, but better if not *too* many articles are affected.

But again: it looks pretty good doesn't it.

Glad you like it. I'm rather fond of it myself

24. Posted by Hien (Moderator 3906 posts) 7y

Quoting Peter

Are you happy for accommodation tables to just not ever be included? Or maybe just the rows with TPIDs in them, since those are the automatic ones?

I don't know how you plan to do it if the exclusions were to be just those with TPIDs. At the moment, the way the table is coded/generated have these "|-" after each and every row. Those would have to be excluded as well, as they form about half of the lines for a table.

I think excluding the entire Accommodation table wouldn't be a bad option to go for. First, it make it easier for you to exclude it. Second, the number of property recommended by a regular member would not be significant enough to make a huge percentage increase to the overall article content.

25. Posted by Lavafalls (Travel Guru 155 posts) 7y

I think Hien has a really good idea

26. Posted by Peter (Admin 5789 posts) 7y

Well, since two of you support the idea of removing the entire accommodation table from calculations, that's what I've done for now. I've also tidied the code up a little to exclude lines with just "|-" on them (could be a lot in normal tables, ie.. Asia).

The shares won't be immediately reflected. An edit needs to happen on the articles first and then they are put in queue to be recalculated. I think that's set to run every 10 minutes. So 10 minutes or so after editing an article, you should see the change in contribution shares.

27. Posted by Peter (Admin 5789 posts) 7y

Actually, I want to discuss another thing that Michael brought up -- the subheadings.

I'm actually of the opinion that we should remove them. There is only room for one accommodation table on a page (in the code, it wouldn't be handled if there were more) and I think having all the listings grouped together is not a bad thing. I also always find it very difficult to separate accommodation between mid-range and luxury particularly. It really depends who you are - some people consider 4 star hotels luxury and some mid-range. What might make more sense is to add in a "Class" column in the table, where we can say how many stars it has (if it's a hotel).

I guess I'm also just keen on avoiding empty subheadings if we don't need them :)

Thoughts?

28. Posted by Hien (Moderator 3906 posts) 7y

Quoting Peter

Well, since two of you support the idea of removing the entire accommodation table from calculations, that's what I've done for now. I've also tidied the code up a little to exclude lines with just "|-" on them (could be a lot in normal tables, ie.. Asia).

The shares won't be immediately reflected. An edit needs to happen on the articles first and then they are put in queue to be recalculated. I think that's set to run every 10 minutes. So 10 minutes or so after editing an article, you should see the change in contribution shares.

Can you manually run a custom script to re-calculate all articles that have been edited in the past couple of days? I foresee many articles having to wait for a very long time before someone makes an edit for the re-calculation to kick in.

29. Posted by Peter (Admin 5789 posts) 7y

Yes, I could of course do that :) Might write one tomorrow. Some of these might indeed be a long time before they get edited again.

30. Posted by Hien (Moderator 3906 posts) 7y

Quoting Peter

Actually, I want to discuss another thing that Michael brought up -- the subheadings.

I'm actually of the opinion that we should remove them. There is only room for one accommodation table on a page (in the code, it wouldn't be handled if there were more) and I think having all the listings grouped together is not a bad thing. I also always find it very difficult to separate accommodation between mid-range and luxury particularly. It really depends who you are - some people consider 4 star hotels luxury and some mid-range. What might make more sense is to add in a "Class" column in the table, where we can say how many stars it has (if it's a hotel).

I guess I'm also just keen on avoiding empty subheadings if we don't need them :)

Thoughts?

I agree. Since the guide have gone this direction of using the table for the Sleep section, it makes not much sense to subdivide it further. If there's a need, we could just use the plain old paragraphing style.