Skip Navigation

Error when editing articles

Travel Forums Wiki Travel Guide Error when editing articles

Page
  • 1
  • 2

Last Post

1. Posted by Utrecht (Moderator, 5555 posts) 16 Feb '10 06:53

Thought it might be handy to post it here, have send PM to Peter as well.

When editing article in the guide, it gives an error, though the edit has been saved.
It also seems to show up on the right in the recent changes, but when clicking on that to view the complete list, the changes are not here.
Check Nigeria and Niger for example.

Bug related to accom table/sleepBot?

Strangely enough, my edit of Tanah Rata shows, but the others don't???

[ Edit: Edited on 16-Feb-2010, at 06:54 by Utrecht ]

2. Posted by Peter (Admin, 5459 posts) 16 Feb '10 14:48

Yes, definitely related to the sleepbot. It was affecting articles that didn't have a city linked yet - of course country articles don't. The error happened just before the change was logged that shows up on the recent changes page.

Should be all fixed now.

3. Posted by Herr Bert (Moderator, 1370 posts) 17 Feb '10 13:53

On the top of the edit section, all the buttons have disappeared. Most of them are in code under the section as well but maybe for some people less understandable.

As it occurs together with the introduction of the sleepbot, I assume it is related to that as well.

Another question about the sleepbot, would be if it can recognise neighbourhoods. I saw that in Belgium: Anderlecht has one hotel, but it is a neighbourhood of Brussels. I added this hotel to Brussels recently (manualy). I don't know if the sleepbot, would throw that one out again, as it doesn't match with Brussels. Also I don't know if there are more of these cases. (Kaprun and Zell am See, could be added together as well, although there are a few kilometres between the two towns.)

4. Posted by Utrecht (Moderator, 5555 posts) 18 Feb '10 00:09

Agree with HerrBert, but be careful not to merge to many places, mostly they can have both accoms within their towns boundaries and just having two articles is better.

Still, another thing, as we are talking about it: yesterday I mad the article Isla Margarita. When matching the accom table with Isla Margarita, it was empty, but matching it with Margartia Island did work. I think it's undoable to prevent it totally, but in this case, just one of the two could be deleted.

Before, I just checked both when adding the accom table and just added the largest one which had most accoms. Isn't there any way anymore to check before saving how many there are? Mainly when a comparison like mentioned above (Isla Margarita versus Margarita Island) is the case.

He..I just noted that in my original post the Nigeria and Niger articles link just like it would for anyone. It thought I could see the whole url

[ Edit: Edited on 18-Feb-2010, at 00:11 by Utrecht ]

5. Posted by Peter (Admin, 5459 posts) 18 Feb '10 15:16

Quoting Herr Bert

On the top of the edit section, all the buttons have disappeared. Most of them are in code under the section as well but maybe for some people less understandable.

Probably a browser bug. It's showing for me on Firefox 3.6. I did make some changes to the javascript on that page, so I'll run some tests on IE and see what the problem might be.

Another question about the sleepbot, would be if it can recognise neighbourhoods. I saw that in Belgium: Anderlecht has one hotel, but it is a neighbourhood of Brussels. I added this hotel to Brussels recently (manualy). I don't know if the sleepbot, would throw that one out again, as it doesn't match with Brussels. Also I don't know if there are more of these cases. (Kaprun and Zell am See, could be added together as well, although there are a few kilometres between the two towns.)

I don't really think this is something I can achieve. Not without some serious messing around in any case. If you have copied a property from another city into the Brussels list, then yes, it will be removed the first time Sleepbot comes around. This is an inevitable sacrifice I had to make to make this work.

However, if you then add it in again, the system will know what you were the one who put it there and from then on will never touch that specific property. That means no automatic updates for that property in that article, but also no removals. It will also recognise that someone has manually removed the property from the Anderlecht article and will not attempt to put it back in again. The problem will basically be fixed for edits from here on in - just not for the old ones. It's a shame a few edits will be lost, but considering the bot should be able to keep these property lists much more accurate and up-to-date than we would ever be able to, I think it's worth it.

Still, another thing, as we are talking about it: yesterday I mad the article Isla Margarita. When matching the accom table with Isla Margarita, it was empty, but matching it with Margartia Island did work. I think it's undoable to prevent it totally, but in this case, just one of the two could be deleted.

Will have a look. It shouldn't be showing all the cities that don't have properties. And I can probably quite easily put in a property count next to the accommodation name in the drop down as well.

It thought I could see the whole url

For moderators, there is a bit of code that will reveal the full url - this is just so you can quickly know where it's pointing without actually having to click on it or hover over it.

6. Posted by Peter (Admin, 5459 posts) 18 Feb '10 17:23

Ok, have fixed the cities list problem (might be some are still cached for a little while). It will now only show those cities with accommodation. Shouldn't have ever shown ones without - thanks for pointing it out.

Also resolved the missing toolbar. Be sure to hit refresh - the javascript might be cached for you.

7. Posted by Utrecht (Moderator, 5555 posts) 19 Feb '10 06:14

Thanks Peter!

Will have a look, I remember that especially the USA had like a list of hundreds, if not a couple of thousand places from which you can choose, while just like a few dozen who actually have accoms (like mentioned in the project popular places) are actually there.

Regarding the url: I can't see it now, while I should in this travelguide forum. I used to see the full url, but now only the link like any other.

Cheers
Michael.

8. Posted by Herr Bert (Moderator, 1370 posts) 19 Feb '10 12:30

Toolbar is back in IE (at work and at home) :)

9. Posted by Herr Bert (Moderator, 1370 posts) 19 Feb '10 12:40

Quoting Peter

I don't really think this is something I can achieve. Not without some serious messing around in any case. If you have copied a property from another city into the Brussels list, then yes, it will be removed the first time Sleepbot comes around. This is an inevitable sacrifice I had to make to make this work.

However, if you then add it in again, the system will know what you were the one who put it there and from then on will never touch that specific property. That means no automatic updates for that property in that article, but also no removals. It will also recognise that someone has manually removed the property from the Anderlecht article and will not attempt to put it back in again. The problem will basically be fixed for edits from here on in - just not for the old ones. It's a shame a few edits will be lost, but considering the bot should be able to keep these property lists much more accurate and up-to-date than we would ever be able to, I think it's worth it.

The thing is that there is no article for Anderlecht, and in my view there shouldn't be one, as it is a neighbourhood of Brussels. I don't know why it is listed under Anderlecht in the hotel database as all. If that is a choice of the hotel themselves, it is their own loss.

10. Posted by Utrecht (Moderator, 5555 posts) 21 Feb '10 05:48

Quoting Herr Bert

Quoting Peter

I don't really think this is something I can achieve. Not without some serious messing around in any case. If you have copied a property from another city into the Brussels list, then yes, it will be removed the first time Sleepbot comes around. This is an inevitable sacrifice I had to make to make this work.

However, if you then add it in again, the system will know what you were the one who put it there and from then on will never touch that specific property. That means no automatic updates for that property in that article, but also no removals. It will also recognise that someone has manually removed the property from the Anderlecht article and will not attempt to put it back in again. The problem will basically be fixed for edits from here on in - just not for the old ones. It's a shame a few edits will be lost, but considering the bot should be able to keep these property lists much more accurate and up-to-date than we would ever be able to, I think it's worth it.

The thing is that there is no article for Anderlecht, and in my view there shouldn't be one, as it is a neighbourhood of Brussels. I don't know why it is listed under Anderlecht in the hotel database as all. If that is a choice of the hotel themselves, it is their own loss.

You could always start a Brussels/Anderlecht article, like there are of neighbourhoods of Chicago, NY or London.