Skip Navigation

Should the private messages be copied in your notification?

Travel Forums System Talk Should the private messages be copied in your notification?

Page

Last Post

21. Posted by Sander (Moderator, 4394 posts) 23 Dec '13 14:08

The "last post" link (both from the forum index, and in the navigation) isn't taking deleted (but shown) posts into account yet. It currently links to #Post19 - even though the thread goes up to #Post20 (both +1 after this reply, undoubtedly).

22. Posted by Sander (Moderator, 4394 posts) 23 Dec '13 14:09

Worse: Because of that, the navigation doesn't show the next page until that page has gotten two replies! Right now "last post" goes to &start=11#Post20 - but should be going to &start=21#Post30 - and page 3 isn't linked up at all!

This gets really bad in long-lived threads which have had a lot of spam deleted. The "criminal record" thread only shows 58 pages - but actually has 61 pages, with no way to navigate to those newer pages other than URL hacking.

[ Edit: Edited on 23-Dec-2013, at 14:12 by Sander ]

23. Posted by ruthbriggs (Inactive, 29 posts) 23 Dec '13 23:36

I think yes, as we can see what the message says and decide weather to log travellerspoint or not, it will save time, but must need a button for spam voting

24. Posted by Peter (Admin, 5465 posts) 24 Dec '13 02:08

Urgh, well that's annoying. I've put in a patch for these particular cases now. There may very well be some other remaining spots with the same problem, but I'll look into them after xmas.

25. Posted by Sander (Moderator, 4394 posts) 24 Dec '13 02:45

Thread navigation is indeed fixed, but last post from the forum index (the link on the date) still miscounts.

26. Posted by Sander (Moderator, 4394 posts) 24 Dec '13 02:47

Also the forum feature where it shows your own post, after submitting that post, miscounts. (But both survivable until after xmas. Have a good one!) :)

27. Posted by Peter (Admin, 5465 posts) 24 Dec '13 03:41

Ah, missed the main forum index since my fix was in the subindex. Fixed that one and the redirect now too.

Have a great christmas :)

28. Posted by Sander (Moderator, 4394 posts) 24 Dec '13 12:28

Minor numbering inconsistency here. Post 11 was deleted. Post 12 is titled "11." (and has id="Post11"). Same pattern here. Hypothesis: Only seems to occur when there's a single post after the deleted post, so off-by-one error?

[ Edit: Edited on 24-Dec-2013, at 12:30 by Sander ]

29. Posted by mojorob (Moderator, 1044 posts) 25 Dec '13 10:11

Quoting Sander

Minor numbering inconsistency here. Post 11 was deleted. Post 12 is titled "11." (and has id="Post11"). Same pattern here. Hypothesis: Only seems to occur when there's a single post after the deleted post, so off-by-one error?

Seems it can also happen when there are 2 posts after the deleted one - example here where Post 2 has been deleted, and the next two posts showing are currently numbered 2 and 3.

30. Posted by mojorob (Moderator, 1044 posts) 3 Jan '14 08:21

Here's another example thread of numbering that's gone wrong. Currently this one has:

Post 1
Post 2 (was removed by moderator)
Post 2
Post 3
Post 4 (was removed by moderator)
Post 5 (was removed by moderator)
Post 5 (was removed by moderator)
Post 4
Post 5

So there are two 'Post 2', two 'Post 4' and three 'Post 5' that exist.